search

arduino / arduino-builder

A command line tool for compiling Arduino sketches
GNU General Public License v2.0
458 stars 114 forks source link

add #line directive to additional source files #1 #324

Closed slady closed 5 years ago

slady commented 5 years ago

improvement for https://github.com/arduino/arduino-builder/issues/323

slady commented 5 years ago

I realized I made a mistake and forgot the important "QuoteCppString"

matthijskooijman commented 5 years ago

FYI, you could have (force-)pushed to the existing branch to update this PR rather than create a new one (but no harm done of course, just for future reference).

slady commented 5 years ago

Oh sorry, did not know that was possible. Even though experienced with git, I am new to GitHub. Thank you for telling me! BTW, how long could it take for this change to get to the main branch and main build?

FrankBoesing commented 5 years ago

Arduino: Most changes need months(best case) to years - 99% of suggestions are accepted never. For the builder it seems to by slightly better..

slady commented 5 years ago

Thanks for your honest answer, though it was not very encouraging...

FrankBoesing commented 5 years ago

Yes, I'm not sure why they use Github. It's so miselading for others as they think they can contribute and so they spend their free time for nothing...

matthijskooijman commented 5 years ago

In practice, there's a lot more contributions than there is manpower to review, polish and eventually merge them, unfortunately. This seems like a fairly small change, so that makes things easier. I'm not the one that decides whether to merge something, but I can perhaps help things along by providing a review :-)

slady commented 5 years ago

Thank you for trying to help!

slady commented 5 years ago

I double checked the contents of the additional files list, it can contain files with these extensions: .h .c .hpp .hh .cpp .s Hope all of them can start with the #line directive.

matthijskooijman commented 5 years ago

Please reply in the other PR, since here it won't be seen :-)

slady commented 5 years ago

Moved it there. Added a little bit more. Hope somebody reads it in this century.