arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.4k stars 384 forks source link

Add libraries super compatibility and explicit incompatibility in the spec #2149

Open umbynos opened 1 year ago

umbynos commented 1 year ago

Describe the request

Add support for a field named supported in the library.properties library metadata file. This field is a comma-separated list of patterns to match against an FQBN.

This will allow library developers to define the supported boards for the library down to board-level granularity.

The result would be something like this in the library.properties file:

name=Camera
version=1.0
author=Arduino
maintainer=Arduino <info@arduino.cc>
sentence=Camera library for Portenta H7 Vision Shield
paragraph=
category=Other
url=https://github.com/arduino/ArduinoCore-mbed/tree/master/libraries/Camera
architectures=mbed,!avr
supported=*:mbed:portenta,!*:*:nano33ble
#supported=mbed:portenta,!mbed:nano33ble <- without wildcards

This information could be used for applications such as:

Describe the current behavior

Library developers can only indicate compatibility at architecture-level granularity. A library may have dependencies on attributes that only present on a subset of boards of a given architecture.

This means it is not possible for tools to accurately determine whether a specific board is supported by a library.

For example, the "Keyboard" library specifies compatibility with the avr architecture:

https://github.com/arduino-libraries/Keyboard/blob/1.0.4/library.properties#L9

architectures=avr, samd, sam

However, not all AVR microcontrollers have the required native USB capability. This results in inaccurate information about the library's support for those boards.

The library is listed in lib list command output when the FQBN of an unsupported board (e.g., Uno) is specified via the --fqbn flag:

$ arduino-cli lib install Keyboard
Downloading Keyboard@1.0.4...
Keyboard@1.0.4 Keyboard@1.0.4 already downloaded
Installing Keyboard@1.0.4...
Installed Keyboard@1.0.4

$ arduino-cli lib list Keyboard --fqbn arduino:avr:uno
Name     Installed     Available         Location              Description
Keyboard 1.0.4         -                 LIBRARY_LOCATION_USER -

Unsupported boards are included in the automatically generated "Compatibility" list of the library's reference page:

https://www.arduino.cc/reference/en/libraries/keyboard/

Arduino CLI version

0.32.2

Operating system

N/A

Operating system version

N/A

Additional context

The newly added field should be ignored by versions of Arduino development tools that don't have support for the new field. If so, this change would not result in any backwards incompatibility of the libraries that use it.


Relevant code:

https://github.com/arduino/arduino-cli/blob/743c3e9b3c94eded62b44081a03650d571fa230c/arduino/libraries/libraries.go#L78

Related

Issue checklist

umbynos commented 1 year ago

Original reporter @facchinm