Closed cmaglie closed 5 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
47645e9
) 68.90% compared to head (3342945
) 68.92%.
Files | Patch % | Lines |
---|---|---|
...l/arduino/builder/internal/compilation/database.go | 80.00% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please check if the PR fulfills these requirements
See how to contribute
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Should fix a memory access panic during saving of compilation database. This is a tentative fix since the error is so rare that we are unable to reproduce it locally.
What is the current behavior?
This is the reported panic:
This issue is ephemeral, re-running the compile usually leads to a successful compile.
What is the new behavior?
Hopefully, it will always compile successfully.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information