Closed alessio-perugini closed 4 months ago
Attention: 38 lines
in your changes are missing coverage. Please review.
Comparison is base (
205a6a5
) 68.92% compared to head (be0b8c4
) 69.74%. Report is 7 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Please check if the PR fulfills these requirements
See how to contribute
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
We're adding the diagnostics in the preprocessing part.
What is the current behavior?
Currently, the diagnostics are considered only for the sketch compilation.
What is the new behavior?
The diagnostics field will report errors from the preprocessor and the compiler.
Does this PR introduce a breaking change, and is titled accordingly?
Other information
I'm proposing to use a struct that Stores the information of the diagnostics instead of using a callback approach. We can always revert that.