arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.33k stars 375 forks source link

Replaced internal `serialutils` package with the equivalent library #2528

Closed cmaglie closed 7 months ago

cmaglie commented 8 months ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

Just an equivalent code change.

What is the current behavior?

No changes

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

codecov[bot] commented 8 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ec157a8) 68.96% compared to head (af3a39e) 68.99%. Report is 2 commits behind head on master.

Files Patch % Lines
commands/upload/upload.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2528 +/- ## ========================================== + Coverage 68.96% 68.99% +0.02% ========================================== Files 204 203 -1 Lines 20523 20410 -113 ========================================== - Hits 14154 14081 -73 + Misses 5216 5180 -36 + Partials 1153 1149 -4 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2528/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2528/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `68.99% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.