arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.24k stars 370 forks source link

Removed dep from `configuration` package in DiscoveryManager #2568

Closed cmaglie closed 3 months ago

cmaglie commented 3 months ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

Just a small code refactoring.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.48%. Comparing base (0d86bf5) to head (999d73b). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2568 +/- ## ======================================= Coverage 69.47% 69.48% ======================================= Files 205 205 Lines 20203 20204 +1 ======================================= + Hits 14037 14038 +1 Misses 5045 5045 Partials 1121 1121 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2568/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2568/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `69.48% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cmaglie commented 3 months ago

Related to #2565