arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.33k stars 374 forks source link

Fixed extremely rare race condition in DiscoveryManager #2589

Closed cmaglie closed 5 months ago

cmaglie commented 5 months ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

Fix a bug in the discovery manager.

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.50%. Comparing base (2063b6a) to head (092178f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2589 +/- ## ========================================== - Coverage 69.51% 69.50% -0.01% ========================================== Files 207 207 Lines 20280 20285 +5 ========================================== + Hits 14097 14099 +2 - Misses 5069 5071 +2 - Partials 1114 1115 +1 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2589/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2589/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `69.50% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.