use eToken for signing - Githubissues

arduino / arduino-cli

Arduino command line tool

GNU General Public License v3.0

4.24k stars 370 forks source link

Please check if the PR fulfills these requirements

See how to contribute

[X] The PR has no duplicates (please search among the Pull Requests before creating one)
[X] The PR follows our contributing guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] UPGRADING.md has been updated with a migration guide (for breaking changes)
[ ] configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Infra change

What is the current behavior?

The certificate used to sign windows binaries is expiring, and the provider no longer ships a digital one.

What is the new behavior?

We have setup a local runner used to sign.

Does this PR introduce a breaking change, and is titled accordingly?

Other information

TODO:

[x] Remove INSTALLER_CERT_WINDOWS_PFX and use INSTALLER_CERT_WINDOWS_CER
[x] Replace INSTALLER_CERT_WINDOWS_PASSWORD
[x] Add INSTALLER_CERT_WINDOWS_CONTAINER

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.13%. Comparing base (8b78c05) to head (53fa85f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2599 +/- ## ========================================== + Coverage 70.11% 70.13% +0.01% ========================================== Files 222 222 Lines 21124 21124 ========================================== + Hits 14812 14816 +4 + Misses 5135 5132 -3 + Partials 1177 1176 -1 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2599/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2599/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `70.13% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.