arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.23k stars 370 forks source link

[BREAKING] Add protoc `oneof` clause where appropriate. #2608

Closed cmaglie closed 1 month ago

cmaglie commented 1 month ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

Add protoc oneof clause where appropriate.

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Yes.

Other information

Fix #2593

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.95652% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (8b78c05) to head (8290196).

Files Patch % Lines
commands/service_debug_run.go 0.00% 12 Missing :warning:
commands/service_debug.go 0.00% 5 Missing :warning:
commands/service_monitor.go 33.33% 3 Missing and 1 partial :warning:
commands/service_library_uninstall.go 72.72% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2608 +/- ## ========================================== + Coverage 70.11% 70.26% +0.14% ========================================== Files 222 222 Lines 21124 21262 +138 ========================================== + Hits 14812 14939 +127 - Misses 5135 5147 +12 + Partials 1177 1176 -1 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2608/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2608/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `70.26% <86.95%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.