arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.23k stars 370 forks source link

Added more lint checks and fixed some warnings. #2610

Closed cmaglie closed 1 month ago

cmaglie commented 1 month ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

What is the current behavior?

No change

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 53.13433% with 471 lines in your changes are missing coverage. Please review.

Project coverage is 70.26%. Comparing base (ba19a2d) to head (7a20b71). Report is 1 commits behind head on master.

Files Patch % Lines
internal/arduino/cores/packagemanager/loader.go 3.84% 25 Missing :warning:
.../arduino/cores/packagemanager/install_uninstall.go 42.85% 24 Missing :warning:
commands/cmderrors/cmderrors.go 42.10% 22 Missing :warning:
commands/instances.go 18.51% 22 Missing :warning:
internal/arduino/builder/sizer.go 15.00% 17 Missing :warning:
internal/cli/lib/search.go 45.16% 17 Missing :warning:
internal/arduino/cores/packagemanager/profiles.go 20.00% 16 Missing :warning:
commands/service_upload.go 48.00% 13 Missing :warning:
...al/arduino/cores/packagemanager/package_manager.go 40.00% 12 Missing :warning:
internal/arduino/cores/status.go 0.00% 12 Missing :warning:
... and 93 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2610 +/- ## ========================================== - Coverage 70.30% 70.26% -0.04% ========================================== Files 222 222 Lines 21262 21262 ========================================== - Hits 14948 14940 -8 - Misses 5131 5147 +16 + Partials 1183 1175 -8 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2610/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2610/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `70.26% <53.13%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.