arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.23k stars 370 forks source link

gRPC: Added progress callback in CompileServerToStreams adapter #2623

Closed cmaglie closed 4 weeks ago

cmaglie commented 4 weeks ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

I forget to report progress in the gRPC API adapter.

What is the current behavior?

No changes, just an API improvement

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No, because it's already part of a breaking change that has not been released yet.

Other information

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.29%. Comparing base (81d517b) to head (3d074c6). Report is 1 commits behind head on master.

Files Patch % Lines
commands/service_compile.go 40.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2623 +/- ## ========================================== - Coverage 70.30% 70.29% -0.01% ========================================== Files 222 222 Lines 21304 21308 +4 ========================================== + Hits 14977 14978 +1 - Misses 5151 5153 +2 - Partials 1176 1177 +1 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2623/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2623/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `70.29% <50.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.