arduino / arduino-cli

Arduino command line tool
https://arduino.github.io/arduino-cli/latest/
GNU General Public License v3.0
4.38k stars 385 forks source link

Updated pluggable-discovery-protocol-handler library #2707

Closed cmaglie closed 1 month ago

cmaglie commented 2 months ago

Please check if the PR fulfills these requirements

See how to contribute

What kind of change does this PR introduce?

Updates the pluggable-discovery client library.

What is the current behavior?

In some circumstances the pluggable-discovery client panics (in particular if the discovery crashes on startup).

What is the new behavior?

The crashing discovery is handled gracefully.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Upstream fix https://github.com/arduino/pluggable-discovery-protocol-handler/pull/50 Fix #2665

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.68%. Comparing base (23d5036) to head (d57a042). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2707 +/- ## ======================================= Coverage 67.67% 67.68% ======================================= Files 234 234 Lines 22207 22285 +78 ======================================= + Hits 15028 15083 +55 - Misses 5998 6017 +19 - Partials 1181 1185 +4 ``` | [Flag](https://app.codecov.io/gh/arduino/arduino-cli/pull/2707/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/arduino/arduino-cli/pull/2707/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino) | `67.68% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=arduino#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.