search

arduino / arduino-examples

Arduino IDE bundled examples
Creative Commons Zero v1.0 Universal
92 stars 42 forks source link

Update AnalogReadSerial.ino #23

Closed kengdahl closed 3 years ago

kengdahl commented 3 years ago

Fixed faulty link

ubidefeo commented 3 years ago

@per1234 what are you referring to? @kengdahl asked me to merge the PR but I don't fully understand which URL redirects you intend here

per1234 commented 3 years ago

@ubidefeo there was a change to the structure of the documentation content on arduino.cc that changed URLs. Some of the old URLs were not redirected, which was the case with http://www.arduino.cc/en/Tutorial/AnalogReadSerial, which was likely the motivation for this PR.

I see that now http://www.arduino.cc/en/Tutorial/AnalogReadSerial does redirect as it should to the new URL https://www.arduino.cc/en/Tutorial/BuiltInExamples/AnalogReadSerial (thanks!), but I think it's still a good idea to update this URL to point to the new location of the content to avoid relying on the redirect. The same issue occurs in every single example in this repository.

ubidefeo commented 3 years ago

thanks @per1234 , that detail was lost on me. please @kengdahl , if you can set a task to make sure all URLs in this repo are aligned adding the /BuiltinExamples portion of the path. In the meantime I'll merge this one

kengdahl commented 3 years ago

@ubidefeo I'll do that.

per1234 commented 3 years ago

I'll do that.

Forget about it. I went ahead and did it. Please review: https://github.com/arduino/arduino-examples/pull/30