Restrict ArduinoISP name collision fix to ArduinoCore-API 1.0.1 - Githubissues

arduino / arduino-examples

Arduino IDE bundled examples

Creative Commons Zero v1.0 Universal

92 stars 42 forks source link

Restrict ArduinoISP name collision fix to ArduinoCore-API 1.0.1 #24

Closed per1234 closed 3 years ago

per1234 commented 3 years ago

ArduinoCore-API 1.0.1 declares a SPISettings class: https://github.com/arduino/ArduinoCore-API/blob/7c9e4f8abde3ce75234e51c0e5be3083832c3e49/api/ArduinoAPI.h#L31 but ArduinoCore-API 1.0.0 and 1.1.0 don't do this:

https://github.com/arduino/ArduinoCore-API/blob/1.0.0/api/ArduinoAPI.h
https://github.com/arduino/ArduinoCore-API/blob/1.1.0/api/ArduinoAPI.h (https://github.com/arduino/ArduinoCore-API/pull/120) So the previous preprocessor conditional that was added to fix the ArduinoISP sketch for platforms using ArduinoCore-API 1.0.1 actually breaks it for platforms using previous or later versions.

Reference: https://github.com/arduino/arduino-examples/commit/b94e757d7a0c50ffb32c225019197bb387978fee#r44269343