arduino / arduino-ide

Arduino IDE 2.x
https://www.arduino.cc/en/software
GNU Affero General Public License v3.0
2.22k stars 380 forks source link

Scrollbar width non-standard #436

Open tomotvos opened 3 years ago

tomotvos commented 3 years ago

Describe the problem

The width of the scroll bar in the editor panel is too narrow.

To reproduce

  1. Edit a sketch with more than a full screen of lines

Scroll bar appears roughly half the width it should be.

Here you can see it compared against the width of the Chrome browser scrollbar:

image

Expected behavior

The scroll bar should be the standard size for each platform

Arduino IDE version

Original report

2.0.0-beta.8

Last verified with

e17472e

Operating system

macOS

Operating system version

Big Sur

Additional context

Additional reports

per1234 commented 1 year ago

The Theia developers set this non-standard width without providing any justification for doing so:

https://github.com/eclipse-theia/theia/pull/852

The scrollbar width is intended to be configurable, but unfortunately the non-standard width was configured in such a way that causes that configuration to be ignored:

https://github.com/eclipse-theia/theia/issues/11732

My hope is that the bug can be resolved in Theia. If that ends up not being possible, I think it will be important for Arduino to investigate whether there is a way to patch it from the Arduino IDE codebase and ideally to also set the default width in Arduino IDE to the same width as the scrollbar in every non-Theia application ever made.

per1234 commented 1 year ago

The fix for https://github.com/eclipse-theia/theia/issues/11732 was released in Theia 1.33.0. It was introduced into this project via https://github.com/arduino/arduino-ide/pull/2027

So the resolution of this defect is now be possible simply by setting the default values of the editor.scrollbar.horizontalScrollbarSize and editor.scrollbar.verticalScrollbarSize settings to 14