arduino / arduino-ide

Arduino IDE 2.x
https://www.arduino.cc/en/software
GNU Affero General Public License v3.0
2.29k stars 390 forks source link

Moving or copying text by mouse dragging missing icons #507

Open rhormigo opened 3 years ago

rhormigo commented 3 years ago

In the IDE editor Selected text is missing little square icon when dragged, also the + icon missing when +Ctrl for copy on another location

ubidefeo commented 3 years ago

@rhormigo We're not able to reproduce this on Beta 12. Please, next time fill in the Bug report using the provided template, this way you can add IDE version and other important information. Thank you

per1234 commented 3 years ago

I think it's about the text editing convention where you can click and drag selected text.

In some cases (including the IDE editor), the default is that the text is moved by default, but if you hold Ctrl then it becomes a copy. There is a GUI convention that a little + icon is overlayed on the item being dragged when the drop will result in a copy operation: image

The Arduino IDE editor has this text drag and drop capability (enabled/disabled by the editor.dragAndDrop setting).

  1. Select some text in the Arduino IDE editor.
  2. Click and hold on the selected text using the left mouse button.
  3. Continuing to hold down the left mouse button, drag the mouse pointer to another location in the text contained in the editor.
  4. Release the left mouse button. The selected text will be moved from its original location to the location of the mouse pointer when the button was released.
  5. Repeat the process, only this time hold the Ctrl before releasing the mouse button. This time, the original text will remain and a copy of it will be added to the location of the mouse pointer during the button release.

the + icon missing when +Ctrl for copy on another location

I'm not able to reproduce this. Here is how it looks for me: image (behavior is same as VS Code)

I'm also not sure what you mean by "little square icon" @rhormigo. Please post a screenshot of this square icon as it occurs in some other application. In my first screenshot, the approach is taken of indicating the text drag and drop condition by attaching the copied text itself to the mouse pointer, but I don't think that really matches the description of "little square icon". My second screenshot shows how the Arduino IDE only uses a standard mouse pointer when a text drag and drop operation is in progress.

rhormigo commented 3 years ago

Thanks for your detailed post, I usually don't have much time to fill forms and I thought this was auto explanatory as I as posting for IDE 2.0 beta 11 that was current at the post time, I understand there is now a 12, but not chance to look on that yet. Also I was not even sure with so many items that much attention was going to be placed in this little thing ;-) Anyway, so for beta 11, running in Windows 10: I found also that this is a random erratic behavior that changes in time in a same PC. Sometimes is hard to see, sometimes do all the time, sometimes alternates.... I did a video to show this issue/behavior and I was lucky, I can show you alternating between working ok and not. In video V2, near second 10 I successfully copy dragging a comment. Then in second 25 I repeat copy dragging, but the little plus is missing. Again is missing in next copy dragging in second 43. Interestingly however, the little plus shows once the text is dropped. In second 56 I do a move (rather than copy) and ok. I repeat at 1.05 copying and ok again. Even when it works, the little rectangle when moving, or rectangle with plus when copying shown in early versions is way more clear and pro looking. See my video V1.8. It would be nice to have the same old school having that rectangle as it confirms you are in fact dragging to either move or copy that text.

V2-- https://user-images.githubusercontent.com/35308546/138613551-804c9b47-9477-4381-8630-433beaf9b2fb.mp4 V1.8-- https://user-images.githubusercontent.com/35308546/138613545-0ccf57c1-13ea-48ed-ad04-9da7dc3d1349.mp4

rhormigo commented 3 years ago

Hi Per about your comment: I'm also not sure what you mean by "little square icon" This is what I would like to see...

image