arduino / arduino-ide

Arduino IDE 2.x
https://www.arduino.cc/en/software
GNU Affero General Public License v3.0
2.29k stars 389 forks source link

Keyboard bindings do not work properly after change to different keyboard layouts #989

Closed Azurac closed 2 years ago

Azurac commented 2 years ago

Describe the problem

I have a keyboard layout where the letter Y is swapped with Z (Czech). When I try to do Undo operation I need to press Ctrl + Y (Z in English layout) instead of Ctrl + Z (which is presented in the key bindings)

To reproduce

Set a different keyboard layout in your system. Start IDE with your default keyboard layout (e.g. EN) Change it to different layout (e.g. Czech)

Expected behavior

Set a different keyboard layout in your system. Start IDE with your default keyboard layout (e.g. EN) Verify you are typing right characters. Verify Ctrl + Z and Ctrl + Y works as expected. Change it to different layout (e.g. Czech) Verify you are typing right characters. Now Ctrl + Z and Ctrl + Y will work with the same buttons as previously, no matter the keyboard layout is.

Arduino IDE version

2.0.0-rc6-nightly-20220514

Operating system

Windows

Operating system version

10

Additional context

No response

Issue checklist

kittaakos commented 2 years ago

Upstream problem https://github.com/eclipse-theia/theia/issues/11688

samtd commented 1 year ago

I check with version 2.0.2 and the problem persist. The key number one don't work. Portuguese Keyboard

kittaakos commented 1 year ago

I check with version 2.0.2 and the problem persist

OS?

The key number one don't work.

Please explain what's not working.

Portuguese Keyboard

Here are the supported keyboard layouts in Theia. The Portuguese ones:

If you are using a Brazilian Portuguese keyboard layout on Windows, we know why it's not working on your side.

samtd commented 1 year ago

Hi kittakos

I'm using Portuguese pt pc keyboard.

Also i already test on version v2.0.3 and the problem maintains. With Arduino 1x i don't have any problem.

kittaakos commented 1 year ago

@samtd, please help us to narrow down the problem. IDE2 builds on the Theia IDE. Could you please get the latest TheiaBlueprint version from https://theia-ide.org/docs/blueprint_download, start it and let us know if you can reproduce the defect? Does the 1 key work with your keyboard layout in the TheiaBlueprint app? Thank you!

samtd commented 1 year ago

@kittaakos, i tested with Theia IDE and works. Theiablueprint cloud: Work Theiablueprint installed v1.32.0: Work arduino-ide_2.0.3_Windows_64bit.zip : Dont Work arduino-ide_2.0.3_Windows_64bit.exe : Dont Work Arduino Web App Version - 6.4.6: Work

Edição Windows 11 Pro Versão 22H2 Instalado em ‎08/‎10/‎2022 Compilação do SO 22621.900

If i use key number 1 with shift it works the correct character "!", but number 1 i can't have all other keys also works

kittaakos commented 1 year ago

Thanks for the investigation, @samtd. Please open a separate issue in this repo. Otherwise, the valuable information you collected might get lost in this closed issue. Thank you!

kittaakos commented 1 year ago

open a separate issue

https://github.com/arduino/arduino-ide/issues/1772