arduino / arduino-language-server

An Arduino Language Server based on Clangd to Arduino code autocompletion
GNU Affero General Public License v3.0
117 stars 11 forks source link

Update go-lsp to v0.1.1 #149

Closed cmaglie closed 1 year ago

cmaglie commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce?

What is the current behavior? Paths containing # are not correctly translated into file:// URI (the path past the # is transformed into uri fragment and discarded)

What is the new behavior? Paths containing # are correctly translated into file:// URI.

kittaakos commented 1 year ago

Unfortunately, arduino/arduino-ide#1124 is not resolved. I still see errors in the LS logs. I continue the investigation:

{"jsonrpc":"2.0","method":"textDocument/didChange","params":{"textDocument":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma#korte.ino.cpp","version":3},"contentChanges":[{"range":{"start":{"line":2,"character":15},"end":{"line":2,"character":15}},"text":"a"}]}}Content-Length: 225

{"jsonrpc":"2.0","id":"5","method":"textDocument/documentSymbol","params":{"textDocument":{"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma#korte.ino.cpp"}}}
<<<
Content-Length: 103

{"error":{"code":-32602,"message":"trying to get AST for non-added document"},"id":"5","jsonrpc":"2.0"}
>>>
Content-Length: 225
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[],"uri":"file:///private/var/folders/z1/xkw1yh5n7rz4n8djprp1mdn80000gn/T/arduino-language-server1842245322/sketch/alma%23korte.ino.cpp","version":1}}Content-Length: 93

{"error":{"code":-32001,"message":"Line value is out of range (2)"},"id":"2","jsonrpc":"2.0"}
>>>
Content-Length: 225
cmaglie commented 1 year ago

Unfortunately, https://github.com/arduino/arduino-ide/issues/1124 is not resolved. I still see errors in the LS logs. I continue the investigation:

I messed up with the lib version 🤦🏼!

Sorry... it should be fine now.