search

arduino / docs-content

Arduino documentation (docs.arduino.cc)
https://docs.arduino.cc/
Creative Commons Attribution Share Alike 4.0 International
156 stars 367 forks source link

Possible wrong RGB sequence #134

Closed tahunus closed 2 years ago

tahunus commented 2 years ago

In Line 128 of Arduino_MKRIoTCarrier.h the LED instance is created with: Adafruit_DotStar leds = Adafruit_DotStar(NUMPIXELS, DATAPIN, CLOCKPIN, DOTSTAR_BGR); (link to file : https://github.com/arduino-libraries/Arduino_MKRIoTCarrier/blob/master/src/Arduino_MKRIoTCarrier.h)

Which suggests the color sequence is BGR, not RGB. The Adafruit Neopixel library in use, does not have a BGR sequence, but it does have a GRB sequence: https://learn.adafruit.com/adafruit-neopixel-uberguide/arduino-library-use

In any case , the MKR IoT Carrier Cheat Sheet has an error in https://docs.arduino.cc/tutorials/mkr-iot-carrier/mkr-iot-carrier-01-technical-reference#leds where the picture lists how to get the colors using the RGB order https://docs.arduino.cc/static/e66517362e06a9efb932279bbf51e6dc/29114/mkrIotCarrier-leds.png

Then the code below it suggest the sequence green, red, blue: carrier.leds.setPixelColor(index, green, red, blue);

Which works correctly, although it's not the BGR of line 128 of MKRIoTCarrier.cpp

Total confusion

marqdevx commented 2 years ago

We will make a PR on the MKRIoTCarrier library to make the LEDs be RGB as it is more common.

marqdevx commented 2 years ago

Update: Library is OK I will make changes on our documentation to show the correct order, which is RGB

marqdevx commented 2 years ago

Thanks for spotting the issue @tahunus 🙌 It should be fixed now 😄