murilopolese
commented
7 months ago There are a lot of board/disk ifs and elses that we should look into because it's polluting the source code readability quite a bit in my humble opinion. But that is a longer, bigger task, I can (and I assume you too) work with this caveat for a bit longer I think :stuck_out_tongue_winking_eye:
The implementation of both save and finish-renaming-tab are tighter with the flowchart.
Both flowchart and design reference were updated.
Covered a few weird edge cases:
- Renaming a tab of a new file to a file that overwrites. When you cancel the overwrite alert, the file goes back to be a new file.
- Renaming a tab of a file that doesn't exist anymore to a file that exists on the current navigation path.
Renaming tabs turned out to be very similar to the "safe save" procedure but with some additional rules.