[WIP] Add support for an Apple Silicon build target

arduino / lab-micropython-editor

Arduino Lab for MicroPython is an Integrated Development Environment (IDE) for MicroPython.

GNU Affero General Public License v3.0

218 stars 29 forks source link

[WIP] Add support for an Apple Silicon build target #95

Closed mikecee closed 5 months ago

mikecee commented 6 months ago

This change hopefully adds Apple Silicon build support as requested in #19.

A new build matrix os is added. This takes "advantage" of the fact that latest macOS for x64 runners is macOS 13, where the new runners are at least macOS 14.
The force build of x64 on any macOS runner (see package.json) has been removed. In theory, this means that electron-build will generate its artifacts based on the architecture of the runner.

@ubidefeo I understand that priority is for bug fixes etc. This PR is being raised as a starting point only (hence WIP/draft), any feedback would be appreciated.

ubidefeo commented 6 months ago

thank you @mikecee I'm gonna look into this asap, as I also want an M1 build for my machine. I was gonna ask one of our team who's the expert on workflows to give some help on this, but I'll just ask him to review your PR 😜

Over the past few days I've put a lot of time in the upcoming 0.9.0, which is a huge twist on this little editor and addresses pretty much all the problems we had so far. I'm happy to say that this Arduino Lab experiment has received more interest and love over the past few months and I look forward to more users playing with it 😃

ubidefeo commented 6 months ago

hey @per1234

I've requested your review because you're my go-to resource for workflows and actions (and many more things). Would you take a look at your earliest convenience?

Thank you u.

ubidefeo commented 5 months ago

hi @mikecee

I have made a branch to build for both Mac X86 and arm64. Testing right now if it build correctly. My implementation handles artefacts uploads as well, superseding this PR. Thank you so much for the pointer, which was incredibly useful for me to understand how to modify the workflow :)