search

arduino / library-registry

Arduino Library Manager list
https://www.arduino.cc/
Creative Commons Zero v1.0 Universal
223 stars 1.41k forks source link

Add Deneyap Color Converter Arduino Library #2586

Closed DogushC closed 1 year ago

DogushC commented 1 year ago

Add Deneyap Color Converter Arduino Library

github-actions[bot] commented 1 year ago

Hi @DogushC. Your pull request has been detected as something other than a Library Manager submission. A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary: https://github.com/arduino/library-registry/blob/main/README.md#instructions

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/jpconstantineau/BlueMicro_Examples_Arduino_Library

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/cubicleguy/su_arduino_uart

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

:x: ERROR: Arduino Lint found errors with https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Deneyap Renk Donusturme not found in the Library Manager index. Library names are not allowed to    
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

Thanks for your interest in contributing to the Arduino Library Manager index @DogushC Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

:exclamation: NOTE: It is not necessary to open a new pull request. :exclamation:

More information: https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

github-actions[bot] commented 1 year ago

Hi @DogushC. Your pull request has been detected as something other than a Library Manager submission. A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary: https://github.com/arduino/library-registry/blob/main/README.md#instructions

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/cubicleguy/su_arduino_uart

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/jpconstantineau/BlueMicro_Examples_Arduino_Library

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

:x: ERROR: Arduino Lint found errors with https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Deneyap Renk Donusturme not found in the Library Manager index. Library names are not allowed to    
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

Thanks for your interest in contributing to the Arduino Library Manager index @DogushC Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

:exclamation: NOTE: It is not necessary to open a new pull request. :exclamation:

More information: https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

github-actions[bot] commented 1 year ago

Arduino Lint has suggestions for possible improvements to https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

:x: ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict: https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

DogushC commented 1 year ago

@DogushC please revert the whitespace changes you made on lines 23 and 5613 of repositories.txt. You are very welcome to submit a separate pull request to clean up the trailing whitespace, but a submission PR must consist only of adding your repository URL to the list.

Any other changes confuse the automated system.

Thanks. I committed these.

per1234 commented 1 year ago

Thanks! A merge conflict resulted from your fork becoming outdated in the meantime. If you will fix that merge conflict, the submission will be automatically accepted.

You can learn how to do that via the GitHub web interface here:

https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

github-actions[bot] commented 1 year ago

Hi @DogushC A problem was found with your pull request:

:x: ERROR: Pull request removes newline from the end of a file. Please add a blank line to the end of the file.

Please resolve this error. The checks will automatically run again once that is done.

More information: https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/cubicleguy/su_arduino_uart

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

Hi @DogushC. Your pull request has been detected as something other than a Library Manager submission. A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary: https://github.com/arduino/library-registry/blob/main/README.md#instructions

github-actions[bot] commented 1 year ago

A problem was found with your submission https://github.com/jpconstantineau/BlueMicro_Examples_Arduino_Library

:x: ERROR: Submission URL is already in the Library Manager index.

github-actions[bot] commented 1 year ago

:x: ERROR: Arduino Lint found errors with https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: Library name Deneyap Renk Donusturme not found in the Library Manager index. Library names are not allowed to    
       change after being added to the index.                                                                           
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

Thanks for your interest in contributing to the Arduino Library Manager index @DogushC Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

:exclamation: NOTE: It is not necessary to open a new pull request. :exclamation:

More information: https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

DogushC commented 1 year ago

Same as before. Please revert the whitespace changes so the automated system can correctly process you submission.

I did these.

github-actions[bot] commented 1 year ago

Arduino Lint has suggestions for possible improvements to https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

:x: ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict: https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

per1234 commented 1 year ago

@ArduinoBot please check it again

github-actions[bot] commented 1 year ago

Hello! I'm checking your submission again.

github-actions[bot] commented 1 year ago

Arduino Lint has suggestions for possible improvements to https://github.com/deneyapkart/deneyap-renk-donusturme-arduino-library:

Linting library in deneyap-renk-donusturme-arduino-library
INFO: No header file found matching library name (Deneyap_Renk_Donusturme.h). Best practices are for primary header     
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value Deneyap Renk Donusturme is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format       
         (Rule LP010)                                                                                                 
WARNING: library.properties name Deneyap Renk Donusturme contains spaces. Although supported, best practices is to not  
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in deneyap-renk-donusturme-arduino-library/examples/RenkDonusturme

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS
github-actions[bot] commented 1 year ago

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here: http://downloads.arduino.cc/libraries/logs/github.com/deneyapkart/deneyap-renk-donusturme-arduino-library/