Closed schnoberts1 closed 2 months ago
Ok, I see that this was a bug in RC2 that’s been fixed.
I assume therefore that main is legit and I can live off the HEAD commit.
@schnoberts1 yes you should be able to build this from HEAD. Let me know if it does not work.
Thanks for the quick response. On 23 Aug 2024, at 09:59, Mattia Pennasilico @.***> wrote: @schnoberts1 yes you should be able to build this from HEAD. Let me know if it does not work.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
So it would seem to work but I notice that post build it's patched the following files:
modified: variants/GENERIC_STM32H747_M4/cflags.txt
modified: variants/GENERIC_STM32H747_M4/cxxflags.txt
modified: variants/GENERIC_STM32H747_M4/defines.txt
modified: variants/GENERIC_STM32H747_M4/linker_script.ld
modified: variants/GIGA/defines.txt
The patch to the linker script breaks RPC because it removes the openamp section. The others don't seem to make a difference but I'm wary of differences.
We get -fno-exceptions
in the c/cxxflags. I'm cool with this, I don't like with sup++.
It resets CORE_MAJOR etc
diff --git a/variants/GENERIC_STM32H747_M4/defines.txt b/variants/GENERIC_STM32H747_M4/defines.txt
index 1da443e9..e9227958 100644
--- a/variants/GENERIC_STM32H747_M4/defines.txt
+++ b/variants/GENERIC_STM32H747_M4/defines.txt
--DCORE_MAJOR=4
--DCORE_MINOR=1
--DCORE_PATCH=5
+-DCORE_MAJOR=
+-DCORE_MINOR=
+-DCORE_PATCH=
That seems less awesome tbh.
It seems to be dependent on a repo I can't access, see last line.