search

arduino / reference-en

Editable source for the Arduino Reference
https://www.arduino.cc/reference/en/
Other
165 stars 732 forks source link

keyboardBegin.adoc: add Portuguese keyboard layout #913

Closed edgar-bonet closed 1 year ago

edgar-bonet commented 1 year ago

Since commit cbee538 (pull request #77, merged on 2023-02-20), the Keyboard library supports the Portuguese keyboard layout. This pull request adds the layout to the documentation of Keyboard.begin().

This is a draft pull request. Since the latest release of the Keyboard library (1.0.4) does not include the Portuguese layout, this layout is only available on master. I will remove the “draft” status once the layout is available in a released version. Note that the commit message mentions release 1.0.5, which is the expected version number of the next release. If the version number turns out to be different (1.1.0 maybe?), I will amend the commit message.

karlsoderby commented 1 year ago

Hi @edgar-bonet , and apologies for the incredibly late response here. This looks great, and the 1.0.5 version was just released and your commit message is intact.

I saw in the Keyboard library that Hungarian support was added as well (https://github.com/arduino-libraries/Keyboard/pull/84), so I made a suggestion that you also include this.

edgar-bonet commented 1 year ago

Hi @karlsoderby, and thanks for the heads-up! I committed your suggestion, :+1: but then re-sorted the layouts to keep them in alphabetical order. I also removed the draft status, as it was meant to last only until release 1.0.5.

Should I squash the three commits together?

karlsoderby commented 1 year ago

Ah thank you, I did not consider alphabetical order. Yes please do so, and we can merge this PR! Thanks a lot!

edgar-bonet commented 1 year ago

@karlsoderby: OK, done. I squashed the three commits together while rebasing on top of master.

karlsoderby commented 1 year ago

Fantastic. Thank you @edgar-bonet !