search

arduino / uno-r4-wifi-usb-bridge

26 stars 8 forks source link

add Ping #42

Closed paulvha closed 7 months ago

paulvha commented 7 months ago

see issue topic 251

Also need changes for the WiFiS3 library. will make a separate pull request for that.

regards Paul

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

pennam commented 7 months ago

@paulvha please make two separate PR one for ping and one for gettime. Also do not change formatting of codelines not involved in tha changes, or at least make them in a separate commit.

Thanks

paulvha commented 7 months ago

Not sure this mail will ever reach you..

For many hours I have been trying to get pull requests going to add WiFi.PING and WiFi.getTime for the UNOR4WiFi. So far I have failed.

I have created a fork, did a local clone, added the changes locally, pushed it back to my fork, created a pull request and committed that.

The pull request includes all kinds of whitespace and new lines changes that I had not added, but somehow got changed. How to remove them ?

I need to make seperate pull request for PING and getTime.. because they end up in the same pull request. I think I have to create different branches for that but then what? how to use that ?

The main reason is MY LACK OF UNDERSTANDING of the concrete steps to get this done correctly. I have spent a ton of time reading online the many documents and MANY articles about GitHub, but "this big beast is a world on his own".

I am bound to give up, too bad because I know my solutions are working and other users want it.

Any advice is welcome.

regards Paul

Van: Mattia Pennasilico @.> Verzonden: vrijdag 16 februari 2024 11:39 Aan: arduino/uno-r4-wifi-usb-bridge @.> CC: paulvha @.>; Mention @.> Onderwerp: Re: [arduino/uno-r4-wifi-usb-bridge] add Ping (PR #42)

@paulvhahttps://github.com/paulvha please make two separate PR one for ping and one for gettime. Also do not change formatting of codelines not involved in tha changes, or at least make them in a separate commit.

Thanks

— Reply to this email directly, view it on GitHubhttps://github.com/arduino/uno-r4-wifi-usb-bridge/pull/42#issuecomment-1948139028, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2GBPBHSY7JN4CZUQXVWO3YT4ZP5AVCNFSM6AAAAABDI36XROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYGEZTSMBSHA. You are receiving this because you were mentioned.Message ID: @.***>

JAndrassy commented 7 months ago

always create a separate branch for a PR. if you want to modify an existing commit, you can do it localy and then force push the changes to you github fork. if you work in Arduino IDE, I guess you can't turn off the trailing spaces removal. and I don't know what your other options are to open a diff editor and remove the differences.