arduino / uno-r4-wifi-usb-bridge

27 stars 9 forks source link

WiFiS3 add Ping #47

Open paulvha opened 9 months ago

paulvha commented 9 months ago

second attempt to get Ping added. This also requires a change to the Core (submitted separately)

regards, Paul

JAndrassy commented 9 months ago

one AT command would do. in the ESPPing library the version with the host name does hostByName and then calls the IP version. hostByName as first attempts to parse the string as IP address (so it does the same as your PINGIP handler)

paulvha commented 9 months ago

I wanted to provide BOTH options in the user in the sketch either to provide a hostname OR provide an IP. Indeed I could have added an indicator (boolean) to indicate that the provided argument is a hostname or IP-address. But I rather keep it simple..

JAndrassy commented 9 months ago
loat CWifi::ping(IPAddress ip, unsigned int count) {
/* -------------------------------------------------------------------------- */
  return ping(ip.toString().c_str(), count);
}

will work OK in the WiFiS3 library

paulvha commented 9 months ago

That assumes ping will work on the renesas processor... tried that but it does not work..

Regards, Paul

Verzonden vanaf Outlook voor Androidhttps://aka.ms/AAb9ysg


From: Juraj Andrássy @.> Sent: Friday, February 16, 2024 8:25:25 PM To: arduino/uno-r4-wifi-usb-bridge @.> Cc: paulvha @.>; Author @.> Subject: Re: [arduino/uno-r4-wifi-usb-bridge] WiFiS3 add Ping (PR #47)

loat CWifi::ping(IPAddress ip, unsigned int count) { / -------------------------------------------------------------------------- / return ping(ip.toString().c_str(), count); }

— Reply to this email directly, view it on GitHubhttps://github.com/arduino/uno-r4-wifi-usb-bridge/pull/47#issuecomment-1949193269, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2GBPH66ZRTOTQXRF52RGDYT6XCLAVCNFSM6AAAAABDMIWDBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGE4TGMRWHE. You are receiving this because you authored the thread.Message ID: @.***>

JAndrassy commented 9 months ago

please. the ping function used in my snippet is your ping(host, count). only one PING AT command is need.

paulvha commented 9 months ago

change applied and pull request updated.

will also update the bridge pull request to only _PINGNAME in commands

regards, Paul