search

arduinodiscord / bot-legacy

A helpful bot for the Arduino discord community.
https://arduino.cc/discord
GNU General Public License v3.0
15 stars 10 forks source link

added txt, ino, cpp, h, py, and js file extensions to whitelist, and made changes to codeblock tag accordingly. #93

Closed BhendiBoi closed 3 years ago

BhendiBoi commented 3 years ago

in the recent discord remake, discord now previews these files, hence gist and codeblocks are no longer needed, and files can be uploaded directly. although I have made changes to the codeblock tag and the "file debugging is not supported" message, they aren't perfect, so I would like your feedback. sorry @BluLightShow for the constant PR's! :wink:

max-bromberg commented 3 years ago

We're still considering when and how we want to make this move considering the new file previews. A large consideration is that this new view is not supported on mobile yet. When we make the jump we will likely opt for a blacklist rather than a whitelist. I'll leave this PR for now and post an update when we know what we're doing :)

BhendiBoi commented 3 years ago

@BluLightShow I understand. I will wait patiently until you, eli and the community helpers reach a decision about this :smiley: . I hope you are reading this in good health during these uncertain times. Stay safe! :smiley: .

max-bromberg commented 3 years ago

@BluLightShow I understand. I will wait patiently until you, eli and the community helpers reach a decision about this 😃 . I hope you are reading this in good health during these uncertain times. Stay safe! 😃 .

I appreciate it. I will close this and push the changes we decide upon in a separate commit. 👍