search

area17 / blast

Storybook for Laravel Blade 🚀
https://dev.to/area17/getting-started-with-blast-storybook-for-laravel-blade-c5c
Apache License 2.0
268 stars 39 forks source link

Add Laravel 9 support #43

Closed johanvanhelden closed 2 years ago

johanvanhelden commented 2 years ago

Edit: PHP 7 is still supported

johanvanhelden commented 2 years ago

@ifox sorry, i forgot to drop the PHP 7 support. As Laravel 9 is PHP 8 only.

It should be fixed now. But please note that this should be a new major release as it is not backwards compatible.

But I wonder, if in this major release, L7 and L8 should be dropped as wel. Since I don't remember if they are compatible with PHP 8. I don't have any old Laravel projects to test this on.

Edit: Ah, it looks like L6, 7 and 8 run on PHP 8 as well: https://blog.laravel.com/laravel-php-8-support

mrtimbrook commented 2 years ago

@johanvanhelden Thanks for doing this! Can we leave PHP 7 support so we can release as a minor version? I'd like to avoid having to maintain 2 separate versions if possible.

johanvanhelden commented 2 years ago

@mrtimbrook It was a bit difficult to test but I've managed to test it on both a PHP 7.4 version of Laravel 8 and a PHP 8.1 version of Laravel 9 and both seem to be working.

Could you verify this as well?

mrtimbrook commented 2 years ago

Hey! Sorry for the delay. Thanks for making that update, this all looks great!