area17 / twill

Twill is an open source CMS toolkit for Laravel that helps developers rapidly create a custom admin console that is intuitive, powerful and flexible. Chat with us on Discord at https://discord.gg/cnWk7EFv8R.
https://twillcms.com
Apache License 2.0
3.72k stars 568 forks source link

Disable heading extension if it's not in the toolbar #2511

Closed Tofandel closed 3 months ago

Tofandel commented 6 months ago

Description

Since tiptap still allows html based on the extensions configured, if we disallow headings we need to let the extension know as well that it shouldn't load

Fixes #2489

AidasK commented 6 months ago

Wow, thank you a lot @Tofandel!

Afting commented 4 months ago

Can you merge this @Tofandel?

ifox commented 4 months ago

@Tofandel doesn't have merge permissions on this repository.

We're working on Twill 3.3 with Laravel 11 support and this PR and many other will be included.

AidasK commented 4 months ago

Wow, thanks @ifox, any eta for 3.3? We are trying to decide if we should fork this project or just wait for 3.3, so eta would be super helpful for our planning.

Tofandel commented 4 months ago

I already forked it with all my PR's if you want to use my branch until then, you can override in composer with my 3.x branch