search

area17 / twill

Twill is an open source CMS toolkit for Laravel that helps developers rapidly create a custom admin console that is intuitive, powerful and flexible. Chat with us on Discord at https://discord.gg/cnWk7EFv8R.
https://twillcms.com
Apache License 2.0
3.63k stars 560 forks source link

[4.x] Make laravel-azure-storage a suggested dependency #2570

Open Tofandel opened 3 months ago

Tofandel commented 3 months ago

Description

matthewbdaly/laravel-azure-storage is present in require of composer but not used anywhere from what I see

It also triggers a warning Package matthewbdaly/laravel-azure-storage is abandoned, you should avoid using it. Use https://github.com/Azure-OSS/azure-storage-php instead.

ifox commented 1 month ago

Hi @Tofandel this dependency is actually used when using azure in MEDIA_LIBRARY_ENDPOINT_TYPE and/or FILE_LIBRARY_ENDPOINT_TYPE.

Unfortunately it looks like efforts to maintain this integration for Laravel have stalled since Microsoft deprecated their SDK.

We could remove the dependency and document installation or even install it dynamically if the azure type is used for now.

Tofandel commented 1 month ago

Then yes it should be in suggest dependencies and documented in the configuration of MEDIA_LIBRARY_ENDPOINT_TYPE and also using the new recommended lib now, removing it from dependencies now has to be done in v4 though (but changing it to a newer one can be done in v3)

ifox commented 1 month ago

I agree, but unfortunately the recommended library has no release yet.