modified after save handlers for medias and files

area17 / twill

Twill is an open source CMS toolkit for Laravel that helps developers rapidly create a custom admin console that is intuitive, powerful and flexible. Chat with us on Discord at https://discord.gg/cnWk7EFv8R.

https://twillcms.com

Apache License 2.0

3.75k stars 572 forks source link

modified after save handlers for medias and files #2625

Closed zeezo887 closed 2 months ago

ifox commented 3 months ago

@Tofandel we noticed a regression on Twill 3.3 following your last PR touching this. Would you mind reviewing this?

Tofandel commented 3 months ago

What is the regression? I'm having a hard time understanding what is this PR achieving that sync doesn't

ifox commented 3 months ago

There are multiple reports since 3.3 where subsequent saves of medias fields are resulting in incorrect pivot rows in the twill_mediables table.

https://discord.com/channels/811936425858695198/1254442932400816148

https://discord.com/channels/811936425858695198/1254726742556414062