search

area17 / twill

Twill is an open source CMS toolkit for Laravel that helps developers rapidly create a custom admin console that is intuitive, powerful and flexible. Chat with us on Discord at https://discord.gg/cnWk7EFv8R.
https://twillcms.com
Apache License 2.0
3.74k stars 569 forks source link

create unittests #356

Closed Gummibeer closed 4 years ago

Gummibeer commented 5 years ago

Atm there is not a single test for anything in the package!?

This should be changed - it would make it easier for contributors to know if they break something and give all a better feeling to merge/release anything.

ifox commented 5 years ago

Totally hear you @Gummibeer!

We do have some tests in our host Laravel apps that are testing authorization thoroughly and help with sanity testing that all routes of a Twill module are successful, that models are created and updated successfully, etc... but we indeed do not have testing setup in Twill itself using Orchestra for the backend or vue-test-utils for the frontend at the moment. It is definitely at the top of our list of improvements and we'd of course welcome any help from the community.

Gummibeer commented 5 years ago

I would like to help but one of the repo admins has to enable StyleCI, TravisCI/CircleCI and all the great tools.^^ I would think that we should start with a simple setup and don't start with a 9x% coverage. This would allow to add unittests for upcoming bugs and also add the planned ones time after time.

I would like to help, and also offer to create the basic php unittests setup. But I can't help with frontend/vue.

Let me know if you want me doing it.

titantwentyone commented 4 years ago

I would like to help with this also. Think it would be hugely beneficial to the project. I'm just starting out with Twill and have dived into the source so no expert (yet!) but will help if I can.

ifox commented 4 years ago

Hi @Gummibeer! Sorry for the delay in getting back to you. We're working on setting all the tools up right now with the help of @antonioribeiro! Once this is ready, we will of course welcome community contributions to improve our test coverage and code quality.

Thank you so much for offering your help too @titantwentyone!

antonioribeiro commented 4 years ago

I just sent a PR to provide the test environment and some of those tools @Gummibeer mentioned:

https://github.com/area17/twill/pull/419