jmkao
commented
8 years ago Oh no, acceptsFile() is definitely not corrupting the file! The issue is that because acceptsFile() is being invoked for all the files in the directory constantly, if there is a single corrupt file in the directory, the whole page will fail.
I think the issue is in this call sequence starting with the REST endpoint for listing printables in PrintableService.java:
@GET
@Path("list")
public List<Printable> getPrintables() {
File dir = HostProperties.Instance().getUploadDir();
File[] acceptedFiles = dir.listFiles();
ArrayList<Printable> printables = new ArrayList<Printable>();
for(File file : acceptedFiles) {
PrintFileProcessor<?> processor = PrintFileFilter.INSTANCE.findAssociatedPrintProcessor(file);
printables.add(new Printable(file, processor));
}
return printables;
}This calls findAssociatedPrintProcessor() in PrintFileFilter.java for each file in the /tmp/uploaddir directory:
public PrintFileProcessor<?> findAssociatedPrintProcessor(File pathname) {
for (PrintFileProcessor<?> currentProcessor : HostProperties.Instance().getPrintFileProcessors()) {
if (currentProcessor.acceptsFile(pathname)) {
return currentProcessor;
}
}Which then shops out the file to every processor, calling acceptsFile() in a loop.
If the acceptsFile() for a processor throws an exception (e.g. in the case of a corrupted zip), then that exception will percolate all the way back to the REST endpoint and cause the listing to fail.
That means that any bad files in /tmp/uploaddir will cause the printables list to be blank.
We can probably reduce the impact of this by adding some exception handling so that bad files will be skipped, but that would still leave the bad file invisibly there and un-removable.
Perhaps there should be some kind of last-resort fallback Processor that gets assigned to the file in a catch block, like "UnprintableFileProcessor" that has enough information to make the file show up in the list (so that it can be removed), but otherwise doesn't do anything.
WesGilster
XiGua89
kloknibor
could not get a better picture. It is just an "x"
if this is right, where/how can I implement these commands?
I am not sure whether this is the right place to post my issue. I successfully installed CWH on the RPi 2. I am able to connect to my printer and move the build-platform. I also ran some test-prints without resin some days ago and everything seemed to work just fine.
Now that my resin arrived I am unable to upload files anymore! 2 hours ago it still worked, now: nothing. I tried several files (.cws maily, but also .stl, .jpg and URLs) and also tried those with different names. Files that I was able to upload before just do not anymore. I am uploading the files from a windows-computer (tried different computers with different browsers as well)
Any help/advice would be greatly appreciated XiGua