area515 / Photonic3D

Control software for resin 3D printers
http://photonic3d.com
GNU General Public License v3.0
133 stars 112 forks source link

Photonic3D Website Status #208

Closed kloknibor closed 8 years ago

kloknibor commented 8 years ago

Hi,

So I tried installing the discourse forum for some hours now... I didn't get it up the way that I wanted so I restored the backup. Installing discourse isn't that hard but discourse likes an server for its own normally... So I have to mess with proxy's to get discourse from port 80... (So I can keep hosting websites on the same server/ip)

I also dislike discourse because it's nested deep into the OS, hard to maintain, also need to install everything seperate, needs a load of resources, needs an proxy etc etc. But still I promised to let you guys test it, I'll try it again later but if someone else wants to give it a try drop me an mail and I'll send you the credentials and make an backup ;)!

Dockers runs without problems by the way :)!

Robin

kloknibor commented 8 years ago

Thanks for the suggestions! I'm gonna look into them. By the way, currently you will be switched to an special mobile template I still need to set up further when you acces the site from a none desktop device. It isn't a special mobile site or anything but it switches the sended template when an tablet or mobile device is detected :)! But well maybe that's also kind of old fashioned... I'll look into the bootstrap templates and will see What I want to do, because I do love the GUI in the wiki at the moment! Maybe I'll make it just one page so they will scroll everything down and add an " back To the Top" button, I think that will be my favourite solution, (also because it's faster to set up) but well bootstrap is cool to!

kloknibor commented 8 years ago

I'm quite busy lately but I did a quick fix for now, maybe I have time this weekend to make the whole page scroll and keep everything where it belongs ;)! The problem was the header, it added 64px outside off the container and the container had an height of 100% so I used CSS3 Height : calc(100%-65px); to solve it for now ;)!

kloknibor commented 8 years ago

The whole page is scrollable so that''s fine but I broke 2 things when editing the javascript :( it doesn't resize with the screen real time anymore only with a refresh and we got too much room at the bottom I can't explain yet :( Unfortunatly I don't have more time today... Will look into it later

kloknibor commented 8 years ago

Do you think it is time to start spreading the word with the warning it's still in beta? or rather just wait?

jmkao commented 8 years ago

We need an operational forum so that when I summon people, they have someplace to talk back to us. If that's ready to go, fix up the http/s endpoints for forum.photonic3d.com and get the categories fully configured; you can use the same ones and the same descriptive text I used in the discourse forum.

Also, I would suggest you spend less time hacking at CSS/JS directly and evaluate different template plugin to figure out the one that best meets our needs out of the box. Something that requires less line-of-code level customization will be less effort to maintain and upgrade in the future.

We're close, but we need to get one level more polished before we're ready to have people come in.

kloknibor commented 8 years ago

Allright your right, also your right about the forums... I really do like Flarum and I think it has potential to be much better than discourse. But at the moment it's still to undeveloped, and for our use case things are going to slow... It's a waste of my time on the forum but that's my fault.

The pasting won't happen anytime soon and I'm starting to get kind of annoyed that the updates of the forum all depend on 1 person, people can do PR's but only 1 person can approve, since he's busy this process is very slow! Also updating is better with discourse and it is just way more mature and active. Well atleast I learned something from it ;)! there aren't developed very much new extensions and only some people are active for the public domain... Also future updates may break extensions and since core functionality comes from extensions it's kind off annoying!

So for now Discourse will be a better choice... I'll play with the header soon ;)!

jmkao commented 8 years ago

@kloknibor I see you're working on the header. One of the changes you made breaks full-screen popups, which include the upload button in a posting, and the "Show" button in http://forum.photonic3d.com/admin/logs/staff_action_logs, which makes it difficult to see what changes were made.

jmkao commented 8 years ago

You also have a bunch of XSS blocked references from the CSS you included:

image

image

For performance and code-separation (since the Hydrogen CSS you are importing from the wiki is complex), you might try using the DOM inspector from Chrome or Firefox to look at the styling of the header and creating HTML with the same style parameters only for the header rather than bringing in the all of the stylesheets, which might bring in behavior that is harder to debug.

That CSS has also created subtle but noticeable changes to various style elements in the forum, like adding in table cell borders where there previously were none (e.g. in the category list) and mis-aligning the Category selector.

kloknibor commented 8 years ago

@jmkao I was aware of these issues but didn't got more time yesterday ;)! The css files I included are way too big I can drop like 90% of the file and that's on the planning, and about the cross-origin loading I was aware too (That's also the reason the menu bar isn't working right sinds it can't find the roboto font). I was working on it yesterdat but had some issues with finding the correct symlinked folder to acces custom uploaded files to forum.photonic3d.com I found it now (in /var/discourse/share I believe at the top of my mind) but it was getting to late to fix it, sorry! The reason the fullscreen pop-ups and show button is broken is probably because of the css ;)! (The unneeded part of the CSS) so that will be easily fixable ;)!

I also tried inline css for the menu bar but that made it just worse to debug... I'll clean the CSS today and add the correct font on the subdomain, that should fix it ;)!

kloknibor commented 8 years ago

@jmkao I broke the login button... if your still logged in can you delete the css for me? (admin -> costumize -> css/html -> header)

kloknibor commented 8 years ago

nevermind I could ofcourse disable the css from their location to fix the problem ;)!

kloknibor commented 8 years ago

everything should be fixed now! @jmkao I reduced it back into one css and only some lines + I added the code on the right domain in the symlinked folder ;)!

jmkao commented 8 years ago

Looking better. There is still something wrong with the layout of the Category selector layout, both in its whitespace and in its alignment.

This is the way it looks on our site:

image

This is the way it should look on the default style:

image

Also, you put a "test test test upload folder" topic under "General". Are those just tests? Or do you refer to the uploaded values?

You should probably put test postings into the "Staff" category so they don't show up for normal users, and uploads that are used should be centralized under the "Assets for Site Design" topic under Staff.

The recommended use of the default categories and topics is documented in https://forum.photonic3d.com/t/read-me-first-admin-quick-start-guide/10

kloknibor commented 8 years ago

Hi thanks for the Feedback! I'll look into it ;)! About the post it can be moved to staff and yes I do refer to the values but they will stay in the same folder so I guess it will go fine, I'll move it. For some reason I can't reach the files inside the symlinked discourse folder unless I got them there with the upload function, have been messing around a while and also found on the internet people did it this way, still kind of strange behaviour, I would expect it just symlinked the complete folder in the website root and you could acces everything in there but that's isn't true... But well it's fine now ;)

Robin

Verstuurd vanaf mijn iPhone

Op 10 mei 2016 om 18:00 heeft James Kao notifications@github.com het volgende geschreven:

Looking better. There is still something wrong with the layout of the Category selector layout, both in its whitespace and in its alignment.

This is the way it looks on our site:

This is the way it should look on the default style:

Also, you put a "test test test upload folder" topic under "General". Are those just tests? Or do you refer to the uploaded values?

You should probably put test postings into the "Staff" category so they don't show up for normal users, and uploads that are used should be centralized under the "Assets for Site Design" topic under Staff.

The recommended use of the default categories and topics is documented in https://forum.photonic3d.com/t/read-me-first-admin-quick-start-guide/10

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub

jmkao commented 8 years ago

Discourse is completely self-contained within the docker container, that ensures that it can be transported cleanly and that backups are complete and repeatable. You should not manually add or link any files under /var/discourse, otherwise there could be negative downstream consequences.

Filesystems within a docker container are ephemeral be default, meaning changes do not persist across restarts of the container. Only specifically mapped locations, which in the case of the Discourse image, are only the log files and database data files, are writeable. This forces a required separation between application and data that forms the basis for reliable upgrades.

Other types of resource sharing outside of the container (e.g. between resources served by two different docker containers or a docker container and a non-containerized app) should be done via URL links and references. That means that if you want wiki.photonic3d.com to provide resources to other subdomains, you'll need to add an Apache directive to have the VirtualHost that provides the shared resource include the necessary CORS header.

This kind of required discipline can make certain customizations more difficult to set up since there a fewer ways to make things work, but with the downstream benefit that only things that are maintainable can be created.

kloknibor commented 8 years ago

I fixed the discourse Forum ;)! thanks for the explaination @jmkao It sure is a learning process for me! But with you guys around it's fun!

kloknibor commented 8 years ago

About the Discourse Forum, I think it's fine for opening ;)! one thing I think is annoying is that after logging in with github/fb/twitter it won't auto refresh to login... You get loggin in only after manually refreshing. This was already this way before I started messing with discourse. I'll look for an solution ;)!

kloknibor commented 8 years ago

Since the server runs debian, won't it be cool to have an demo of our software running on the server? Or will this cause serious security risks? Also it will need to be a version which keeps printing I suppose just like NanoDLP, what do you guys think of this idea?

jmkao commented 8 years ago

I've used the demo that NanoDLP has and found it to be fairly useless. It also opens us up to unknown security risks. The only reason that the NanoDLP trial is useful at all is that they have poor documentation, so you can't tell how it works from reading something, you have to try it yourself.

If we aim to have good docs, that would be a superior option, in my opinion.

jmkao commented 8 years ago

I have updated the Downloads page with more downloads and to reflect a CDN link for the RPi image. I've also created some postings in the forum to put a bit of useful starter content in. If others could contribute descriptions or pictures of their setups in the "Share Your Setup" category, I think that would help in making things seem worth trying.

We should port over some of the basic install docs out of the READMEs for https://github.com/area515/OctoPi and https://github.com/area515/Creation-Workshop-Host into the wiki, or at least link out to them so that people looking to get started won't be stumped.

Then I think we'll be open for business.

kloknibor commented 8 years ago

Sounds good! about the install docs, for the raspberry pi I already made an entry, planning to add more pics and an video soon (still need to edit the clip)

Robin

Verstuurd vanaf mijn iPhone

Op 12 mei 2016 om 07:51 heeft James Kao notifications@github.com het volgende geschreven:

I have updated the Downloads page with more downloads and to reflect a CDN link for the RPi image. I've also created some postings in the forum to put a bit of useful starter content in. If others could contribute descriptions or pictures of their setups in the "Share Your Setup" category, I think that would help in making things seem worth trying.

We should port over some of the basic install docs out of the READMEs for https://github.com/area515/OctoPi and https://github.com/area515/Creation-Workshop-Host into the wiki, or at least link out to them so that people looking to get started won't be stumped.

Then I think we'll be open for business.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub

jmkao commented 8 years ago

Also, can you get rid of the social links at the bottom of the pages in the template?

kloknibor commented 8 years ago

Sure do we want to leave some behind like twitter/facebook for our own pages? Might be a good way to notify users of an new release ;)!

kloknibor commented 8 years ago

@jmkao the new download link is fast enough for me, downloading is only some minutes, shall I pull down the mirror than?

kloknibor commented 8 years ago

done and done ;)! (forum and social links)

kloknibor commented 8 years ago

Sorry guys! I've been busy with graduating lately... Finished my thesis yesterday so will try to finish this up :)!

WesGilster commented 8 years ago

Good job and congratulations.

kloknibor commented 8 years ago

Thank you very much!

WesGilster commented 8 years ago

Not sure that this is the best place to track the website status. If there is something specific feel free to reopen.