search

area515 / Photonic3D

Control software for resin 3D printers
http://photonic3d.com
GNU General Public License v3.0
131 stars 115 forks source link

fullRelease uploads the backwards compatibility zip to releases #220

Closed jmkao closed 8 years ago

jmkao commented 8 years ago

The gradle fullRelease target uploads all of the zip files in the cwd to the release, which picks up the LFS stub cwh-0.298.zip in addition to the cwh-TAG.zip.

This is confusing for users who are downloading the zip manually, and also confuses start.sh.

Need to fix start.sh to be more specific about downloading the release matching the tag (which is the "new world" behavior) and to fix fullRelease to omit the backwards compatibility zip.

WesGilster commented 8 years ago

Quick question on this. I tried to release a dev version, and it didn't promote my release to the "latest". Any idea why that happened?

jmkao commented 8 years ago

I believe github determines the latest release based on the date of the commit that is tagged for the release. It looks like DEV002, photonic-dev003, and photonic-dev004 are all on commit ffda795, which makes Github think that all of those releases are the same. What seems to happen is that when a release is on a newer commit, that release will become the latest. Then if you release again on the same commit, the release will be added, but will not become the latest. I guess this is some kind of comparison rather than sort based behavior.

WesGilster commented 8 years ago

I see that makes sense. Thanks for the help. I was just trying to get rid of a build with a misspelled tag name photomic... Next time I'll check something in before a build to make sure the "latest" is taken.