area515 / Photonic3D

Control software for resin 3D printers
http://photonic3d.com
GNU General Public License v3.0
131 stars 115 forks source link

[small bug] : delete /machine/slicingProfiles/{slicingProfileName} #318

Closed kloknibor closed 7 years ago

kloknibor commented 7 years ago

Hi,

I'm implementing some features to add/remove slicing and resin profiles and it didn't seem to work for a while I got an 204 response back from /machine/slicingProfiles/{slicingProfileName}.

After a while I realised I needed to use " encodeURIComponent" for it to make it work, which it does now. But it does mean that you get a succes reply even when it didn't delete any printers. It's only a small bug and not that important since as soon as the frontend is set op properly it shouldn't go wrong! But it would be nice to get an error response back :)

WesGilster commented 7 years ago

fixed in commit 1882d85761a70ab220b5e27ae68ed7f1a3fd5d1d with tests