search

areaDetector / ADAravis

areaDetector driver for GenICam cameras using the Aravis library on Linux.
https://areadetector.github.io/master/ADAravis/ADAravis.html
6 stars 8 forks source link

use of static variables #16

Closed till-s closed 2 years ago

till-s commented 2 years ago

I was browsing the code and noticed that there are static (i.e., global) variables nConsecutiveBadFrames and nBadFramesPrior. Probably not a huge problem in practice but I thought I bring it to your attention as it may cause confusion if multiple devices are in use and experiencing problems.

MarkRivers commented 2 years ago

@till-s good point, thanks. I have changed those from static variables to private member variables, set to 0 in the constructor initializer list.