search

areaDetector / ADCore

The home of the core components of the EPICS areaDetector software. It includes base classes for drivers and code for all of the standard plugins.
https://areadetector.github.io/master/index.html
Other
20 stars 65 forks source link

Make full filename large enough for filename and filepath components #470

Closed BenBradnick closed 3 years ago

BenBradnick commented 3 years ago

I was having issues with full filenames being truncated due to the full filename being limited to the same size to the filename and filepath components.

This is a minimal change which increases the size of the full filename compared to the filename and filepath components. NDFileNexus.cpp already does something similar, but has a fixed format.

I'm not sure if the factor should be 3*MAX_FILENAME_LEN instead to account for possible extra characters in the file template on top of the substitution (although this will be slightly less than 256 characters depending on the formatting).

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 38.9% when pulling 4a558b88b9319ae88a535709e8b3dc8ec2425e18 on dls-controls:fix/full-filename-length into bcaced94ad48b9bb5fdbd1a7f6d9d8be5c416003 on areaDetector:master.