search

areaDetector / ADCore

The home of the core components of the EPICS areaDetector software. It includes base classes for drivers and code for all of the standard plugins.
https://areadetector.github.io/areaDetector
Other
20 stars 69 forks source link

Github Actions failing due to asyn #495

Open MarkRivers opened 1 year ago

MarkRivers commented 1 year ago

Github actions fails because asyn fails to build due to TIRPC issue.

Is there a way to change the asyn build for Github Actions for ADCore to set CONFIG_SITE to use tirpc?

MarkRivers commented 1 year ago

@ralphlange can you advise on this?

mdavidsaver commented 1 year ago

An example of setting TIRPC=yes from a ci-script hook:

https://github.com/mdavidsaver/ndwarp/blob/cf1bedfd1497dad85ab628c989b694fae11ab75b/.ci-local/defaults.set#L10

https://github.com/mdavidsaver/ndwarp/blob/cf1bedfd1497dad85ab628c989b694fae11ab75b/.ci-local/asyn-config.sh#L9

Although I think a more efficient, although more complex, solution would be for asyn to auto-detect when tirpc is needed. Either from make (cf. https://github.com/epics-modules/asyn/pull/187), or from source with eg. #if __has_include(<tirpc/rpc/rpc.h>).