search

areaDetector / ADGenICam

areaDetector base class for GenICam cameras.
https://areadetector.github.io/master/ADGenICam/ADGenICam.html
7 stars 16 forks source link

Script modified to use correct PV names as in makeEdl.py #2

Closed LeeHudsonDLS closed 4 years ago

LeeHudsonDLS commented 4 years ago

I'm in the process of getting ADGenICam and ADAravis working at diamond and I noticed the script makeEdl.py wasn't using the same PV names as the makeAdl.py script. I've copied the logic across.

MarkRivers commented 4 years ago

That makeEdl.py file in ADGenICam is basically just the makeDbAndEdl.py from aravisGigE with the database building removed. I have not done anything else to it. In addition to changing the PV names you might consider building multiple smaller screens as I do with makeAdl.py. You can also make edl files by first make adl files and then runnning the converter. It does a pretty good job now.

LeeHudsonDLS commented 4 years ago

Apologies for the slow reply, at diamond we've always had a big screen with all the camera specific setting but I agree it would be neater if we split it up. Would it be best to merge this request and once i've done the smaller screens do that in a separate request?

MarkRivers commented 4 years ago

I just want to make sure you know that there is an ADAravis.edl and all of the camera-specific smaller screens for edm in the ADGenICam directory. Have you tried those screens?

LeeHudsonDLS commented 4 years ago

Yes i've just given them a go. I wonder if there's any point in modifying the makeEdl.py script if I can just use the makeAdl.py script and run the converter (probably what you were getting at)? Perhaps having 2 scripts doing very similar things will make it hard work for maintenance. I'll do some more testing with the converter, if I find I don't need to modify them then I see no reason not to use the converter.

MarkRivers commented 4 years ago

If we can eliminate the make Edl.py script that will make it easier to maintain. The autoconverted files seem to look pretty good now.

LeeHudsonDLS commented 4 years ago

Ok I'll do abit of testing today and tomorrow.

LeeHudsonDLS commented 4 years ago

Hi Mark, I think it should be fine to get rid of makeEdl.py entirely, i'm using the makeAdl.py script and converting using adl2edl as suggest and it looks fine.