search

areaDetector / ADSimDetector

A simulation driver for the EPICS areaDetector software. It contains the example driver and an example IOC directory.
https://areadetector.github.io/areaDetector/ADSimDetector/simDetector.html
Other
2 stars 16 forks source link

apply adl2ui conversion #4

Closed prjemian closed 6 years ago

prjemian commented 7 years ago

instead of #2

prjemian commented 7 years ago

images of converted screens

simdetector

simdetectorsetup

prjemian commented 7 years ago

@MarkRivers : Added op/Makefile and op/ui/Makefile with local rules. These should be adapted to the EPICS build system. Perhaps @anjohnson can advise how to convert? Is the advice in /usr/local/epics/base/configure/CONFIG_FILE_TYPE the right place to start?

Let's make it right for ADSimDetector before doing the same with the similar work ADCore.

MarkRivers commented 7 years ago

It would be simpler to just to all the work in op/Makefile, and remove ui/Makefile and ui/autoconvert/Makefile. Then there is just one new file, and not 6 if we support op/edl and op/opi as well.

anjohnson commented 7 years ago

@prjemian I can show you how to export a set of build configuration settings and GNUmake rules from a support module so that other modules pointing to it can use those rules. That might be appropriate if you provided the file converters as support modules, but I suspect that isn't how you want to use them. I'd be happy to meet sometime after the holiday if you want to discuss the build system.

prjemian commented 7 years ago

@anjohnson : Thanks for the offer. See you next week.

@MarkRivers : Shall I pull the rules from the op/edl/Makefile into op/Makefile as well?

MarkRivers commented 7 years ago

I tried doing what I proposed, having just op/Makefile. But I am not sure down to make it work, because adl2ui does not let one set the output file. It always creates file.ui in the current default directory. Is there a way to cd to the ui/autoconvert directory before it runs adl2ui in op/Makefile? If not then I guess we need the multiple Makefiles like you have it?

prjemian commented 7 years ago

I tried that too but had problems with formatting the target of the rule

prjemian commented 7 years ago

got it

prjemian commented 7 years ago

once this is acceptable, do a squash merge

MarkRivers commented 7 years ago

Can one do a squash merge on Github or only with the command line?

anjohnson commented 7 years ago

@MarkRivers If you click the downward arrow in the button to the right of the "Merge pull request" wording it gives you options to do that.