search

areaDetector / ADSupport

Source code for support libraries for areaDetector.
https://areadetector.github.io/areaDetector/user_guide.html
Other
1 stars 15 forks source link

Enable HL API for HDF5 #12

Closed brunoseivam closed 7 years ago

brunoseivam commented 7 years ago

Would it be possible to change the configure flag from --disable-hl to --enable-hl? ADEiger uses the HL API and it would be nice if it could get it from ADSupport.

MarkRivers commented 7 years ago

I can work on that. @ulrikpedersen and @ajgdls do you recall if there was a reason that we were disabling the hl interface? Any problem with SWMR, etc? I have a vague recollection that there was a reason we disabled it?

ulrikpedersen commented 7 years ago

The combination of --enable-hl and --enable-threadsafe flags are not supported by the HDF Group. What that means is that no work have been done to check and implement thread-safety in the HL libs. Presumably if you do not use the HL lib functions from multiple threads you should be OK.

The configuration (cmake/configure) will by default fail if you try to combine these two flags, but the --enable-unsupported flag will override that check. We do use this flag in our build of HDF5 libs at DLS as we don't use HL from multiple threads.

MarkRivers commented 7 years ago

I have added a new ADSupport/supportApp/hdf5_hlSrc directory. This builds the HDF5 hl directory. @brunoseivam can you please make sure it works for your for building the Eiger detector? I would like to release ADSupport R1-3 soon. Thanks.

brunoseivam commented 7 years ago

I'll test it tomorrow and let you know

brunoseivam commented 7 years ago

Looks good to me :+1:

MarkRivers commented 7 years ago

Thanks for doing this do quickly. I'm closing this issue.