Reject invalid PV name at monitor creation.

areaDetector / pvaDriver

An EPICS areaDetector driver for importing an EPICSv4 NTNDArray via pvAccess into an areaDetector IOC.

https://areadetector.github.io/areaDetector/pvaDriver/pvaDriver.html

Other

1 stars 5 forks source link

Reject invalid PV name at monitor creation. #3

Closed brunoseivam closed 7 years ago

brunoseivam commented 7 years ago

Fixes #1

brunoseivam commented 7 years ago

Yes, that method had two-space indentation instead of four like the rest of the file

GDYendell commented 7 years ago

This doesn't seem to work for me. PvName shows and reports up, but I get no frames.

brunoseivam commented 7 years ago

Hi @GDYendell, thanks for catching this, please try again with the correction I just pushed.

GDYendell commented 7 years ago

Yeah that fixes it @brunoseivam

GDYendell commented 7 years ago

Is this likely to become a new release any time soon, @brunoseivam? I would like to make new AD* releases for ADCore 2-6 at DLS around the end of April.

ulrikpedersen commented 7 years ago

Hi @brunoseivam and @MarkRivers

This one works for us (tested by @GDYendell) and we're keen to build and release at DLS. Can we merge it?

Cheers, Ulrik

brunoseivam commented 7 years ago

I think we can. I don't seem to have the appropriate permissions to do it myself...

MarkRivers commented 7 years ago

Merged and released R1-2.

ulrikpedersen commented 7 years ago

Thanks! :+1: