search

aredridel / html5

Event-driven HTML5 Parser in Javascript
http://dinhe.net/~aredridel/projects/js/html5/
MIT License
590 stars 168 forks source link

Make array.last overrideable #100

Closed ibash closed 10 years ago

ibash commented 10 years ago

I just spent a few hours tracking down and ugly bug. Root cause was html5 was using defineProperty for array.last and a separate library was trying to assign a different function to array.last

Best practices for each of these is questionable -- but at the very least, lets make array.last override-able?

aredridel commented 10 years ago

Yeah, this isn't the right solution -- it should just become a plain function like last(array).

I'll look at fixing this if you don't do it first!

aredridel commented 10 years ago

(See #101)