search

aredridel / html5

Event-driven HTML5 Parser in Javascript
http://dinhe.net/~aredridel/projects/js/html5/
MIT License
590 stars 168 forks source link

Remove todos from passing tests #102

Closed aredridel closed 10 years ago

aredridel commented 10 years ago

@danyaPostfactum This prunes the todos from the test output for all the test cases that pass for me.

danyaPostfactum commented 10 years ago

I think we should add github.com/html5lib/html5lib-tests as submodule. Do we really need to split test files into small ones? Thousands of files and folders are not good. I think it would be better to parse whole test files directly from html5-lib-tests, as html5lib-python does.

aredridel commented 10 years ago

I'd be happy with that. I'd love to have it be a separate package -- I started working that direction but didn't finish. It'd keep the download for the main html5 package much smaller.

In general, I prefer a subtree merge to a submodule though.

danyaPostfactum commented 10 years ago

a subtree merge

What does that mean? I am not a experienced git user, but I want something like https://github.com/html5lib/html5lib-python/tree/master/html5lib/tests

So, should we create submodule or do something else?

aredridel commented 10 years ago

See pull #104 for the test data in that form

aredridel commented 10 years ago

It goes like this:

git remote add html5lib-tests https://github.com/html5lib/html5lib-tests
git fetch html5lib-tests
git read-tree -u html5lib-tests/master --prefix tests/data
git commit -m 'Add test data'
git merge -s subtree html5lib-tests/master

To update in the future, the remote would be added if it's not there, the fetch run again, then merge again. No read-tree and commit to update. Just merge the updates.

danyaPostfactum commented 10 years ago

@aredridel thanks. Closing since this is no longer valid.

aredridel commented 10 years ago

woot!