search

aredridel / html5

Event-driven HTML5 Parser in Javascript
http://dinhe.net/~aredridel/projects/js/html5/
MIT License
590 stars 168 forks source link

Zombie.js broken since 0.3.15 #94

Closed sfuentes closed 10 years ago

sfuentes commented 11 years ago

Aloha,

in regards to this issue, i just want to point out that the latest npm release broke zombie.js i wasn't able to track down the cause of the issue, but maybe someone more familiar with this project could point to the root of the cause.

https://github.com/assaf/zombie/pull/582

Kind Regards

aredridel commented 11 years ago

Oh nuts! I'll look!

aredridel commented 11 years ago

What's the breakage?

sfuentes commented 10 years ago

@aredridel no way meant as pushy as it may sound but, do you have any news regarding the issue ?

Kind Regrads

aredridel commented 10 years ago

Not yet -- been fighting an illness, so I've not had the attention it deserves. Hopefully Real Soon Now!

aredridel commented 10 years ago

There are updates on the zombie ticket -- more detail needed!

aredridel commented 10 years ago

This looks like it was caused by @danyaPostfactum updates to the parser spec in 90975c2673b14165060906c7c4951b8eb5990928

aredridel commented 10 years ago

It's a big commit, so dissecting it further is going to be painful. I'll keep working at it!

sfuentes commented 10 years ago

Thx for your Hard work man

aredridel commented 10 years ago

It looks like the error is caused by reentrant parsing clearing the document (triggered by an innerHTML injection inside jQuery, quite normal) in parse_fragment. I'll keep diagnosing.

aredridel commented 10 years ago

Please let me know if this doesn't cover your use case: It makes the zombie test suite pass more tests, but not completely for me. The integration is non-trivial, so there may be more to chase down.