search

arefaslani / next-boilerplate

Minimal Next.js boilerplate
149 stars 21 forks source link

cleanup #1

Open mihaiserban opened 6 years ago

mihaiserban commented 6 years ago

Hi,

First thanks for the boilerplate 👍🏻

package.json should be cleaned up. For example i see packages like next-redux-wrapper, but you're not using the redux wrapper anywhere. It would also simplify the pages if the redux wrapper were used in a layout component, and pages only connected to the store.

    "next-redux-saga": "2.0.1",
    "next-redux-wrapper": "^1.3.4",
arefaslani commented 6 years ago

Hi @mihaiserban!

For example i see packages like next-redux-wrapper, but you're not using the redux wrapper anywhere.

We use next-redux-wrapper here

It would also simplify the pages if the redux wrapper were used in a layout component, and pages only connected to the store.

Agreed!

package.json should be cleaned up.

It's some time that we want to cleanup our projects. For example this boilerplate and next-images. Unfortunately we are so busy at the moment. Could you please make a pull request with all the cool stuff you suggested?