search

aregm / nff-go

NFF-Go -Network Function Framework for GO (former YANFF)
BSD 3-Clause "New" or "Revised" License
1.38k stars 154 forks source link

Implemented send/receive statistic counters for #390 #564

Closed gshimansky closed 5 years ago

ifilippov commented 5 years ago

I'm concerned about list of functions.

So we don't want read and write? (if so please remove from their parameters).

Also generate is not inside segment - you can simply place counters their (and it was initial request as I remember)

Also Stop will be quite useful - it is in C - so little changes will be required.

Am I right?

gshimansky commented 5 years ago

I'm concerned about list of functions.

So we don't want read and write? (if so please remove from their parameters).

Also generate is not inside segment - you can simply place counters their (and it was initial request as I remember)

Also Stop will be quite useful - it is in C - so little changes will be required.

Am I right?

Ok I added read, write and generate back to how they were implemented originally, only using RXTXStats and never filling up dropped packets. Stop function is done once globally for the whole system.