aregm / nff-go

NFF-Go -Network Function Framework for GO (former YANFF)
BSD 3-Clause "New" or "Revised" License
1.38k stars 156 forks source link

SetSenderOS not working in 0.9.1 #696

Open shahrukh668 opened 4 years ago

shahrukh668 commented 4 years ago

I recently set-up a newer version of nff-go (0.9.1) while i also have an older version of nff-go set-up in a different environment. I am facing error using SetSenderOS in nff-go-0.9.1 it gives an error (panic: interface conversion: interface {} is nil, not int) whereas the same code is running fine in my older nff-go. Is this a bug or am i missing something?

this is how i am using SetSenderOS: flow.CheckFatal(flow.SetSenderOS(tempFlow, "em4"))

attached is the screenshot of the error I am getting. interface

shahrukh668 commented 4 years ago

I found a difference in flow.go between both versions which is causing the issue.

this is in 0.9.1, this gives error: 0 9 1

This is in the older version i had, this works fine: othernffgo

Is there any way i can check the version of nff-go i have? As the flow.go code on this repo is the same as my older nff-go code.

mzeeshan1 commented 4 years ago

one way to do it would be check release from github and clone that code

shahrukh668 commented 4 years ago

one way to do it would be check release from github and clone that code

That would be for a fresh clone... I meant my local clone...

mzeeshan1 commented 4 years ago

one way to do it would be check release from github and clone that code

That would be for a fresh clone... I meant my local clone...

just run git tag from your nff-go clone that should show you the version

shahrukh668 commented 4 years ago

one way to do it would be check release from github and clone that code

That would be for a fresh clone... I meant my local clone...

just run git tag from your nff-go clone that should show you the version

ohhh... that's intelligent... but what if someone deletes the .git files?