search

arei / npmbox

Utility for creating (boxing) and using (unboxing) an archive of a complete (including all dependencies) npm install.
MIT License
245 stars 34 forks source link

Bugfix/24 offline installation isnt working #39

Closed billyjf closed 7 years ago

arei commented 9 years ago

Really appreciate the PR. Would you consider integrating this into the node code instead of as a bash script? That way it works on more platforms. Maybe as a separate command like npmbox-itself or something? I am not really keen on a script that is OS dependent.

Thoughts?

billyjf commented 9 years ago

Hey Glen,

I will take a look at the node code this weekend and see if I can get the refactoring to test out.

The test still must be OS specific in my opinion however. How else would you bring up the firewall to conduct the offline test after building the offline tarball? I do agree being so Debian tied for ufw testing is a limiting factor. I'll take a look at re-factoring the bash from Debian based to be iptables based, which would be far more inclusive across many different distros. I still think Bash lends itself very well to this kind of build test though.

Thank You, Billy

Sent from my iPhone

On Oct 15, 2015, at 1:25 PM, Glen R. Goodwin notifications@github.com wrote:

Really appreciate the PR. Would you consider integrating this into the node code instead of as a bash script? That way it works on more platforms. Maybe as a separate command like npmbox-itself or something? I am not really keen on a script that is OS dependent.

Thoughts?

— Reply to this email directly or view it on GitHub.

billyjf commented 9 years ago

Long term it would be even nicer to get some pull requests approved for npm integration :)

Sent from my iPhone

On Oct 16, 2015, at 9:49 AM, Billy Fisher billyjfisher@gmail.com wrote:

Hey Glen,

I will take a look at the node code this weekend and see if I can get the refactoring to test out.

The test still must be OS specific in my opinion however. How else would you bring up the firewall to conduct the offline test after building the offline tarball? I do agree being so Debian tied for ufw testing is a limiting factor. I'll take a look at re-factoring the bash from Debian based to be iptables based, which would be far more inclusive across many different distros. I still think Bash lends itself very well to this kind of build test though.

Thank You, Billy

Sent from my iPhone

On Oct 15, 2015, at 1:25 PM, Glen R. Goodwin notifications@github.com wrote:

Really appreciate the PR. Would you consider integrating this into the node code instead of as a bash script? That way it works on more platforms. Maybe as a separate command like npmbox-itself or something? I am not really keen on a script that is OS dependent.

Thoughts?

— Reply to this email directly or view it on GitHub.

danfuzz commented 8 years ago

BTW you can test offline on a Posix-ish system by setting the environment variable HTTPS_PROXY to a valid but unreachable/unresolvable URL, e.g. literally http://xxx.yyy/zzz. If you do this, then any time npm goes to perform network access, it will hit that URL and fail loudly.

In addition to respecting that env var, npm will accept the option --https-proxy. If npmunbox included code to set that option directly when calling into npm, you wouldn't have to bother with any external trickery.